NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: port-arm/53171 (Broadcom (and other ARM SoC i2c drivers) mis-handle indirect configuration of devices)

The following reply was made to PR port-arm/53171; it has been noted by GNATS.

From: Jared McNeill <jmcneill%invisible.ca@localhost>
To: Jason Thorpe <thorpej%me.com@localhost>
Cc: gnats-bugs%NetBSD.org@localhost,
 Jason Thorpe <thorpej%NetBSD.org@localhost>,
 port-arm-maintainer%netbsd.org@localhost,
 netbsd-bugs%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost
Subject: Re: port-arm/53171 (Broadcom (and other ARM SoC i2c drivers)
 mis-handle indirect configuration of devices)
Date: Mon, 30 Apr 2018 17:38:33 -0300

 --Apple-Mail=_4FA40B50-3E1E-4320-993F-8BB7A77FD40B
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/plain;
 	charset=utf-8
 
 On Apr 30, 2018, at 5:21 PM, Jared McNeill <jmcneill%invisible.ca@localhost> =
 wrote:
 >=20
 >=20
 >> On Apr 30, 2018, at 5:16 PM, Jared McNeill <jmcneill%invisible.ca@localhost =
 <mailto:jmcneill%invisible.ca@localhost>> wrote:
 >>=20
 >> I thought we had some drivers that relied on this but when I went to =
 look I couldn=E2=80=99t find any..
 >=20
 > Ok I found one! It=E2=80=99s clearly broken..
 >=20
 > https://nxr.netbsd.org/xref/src/sys/dev/i2c/ibmhawk.c#96 =
 <https://nxr.netbsd.org/xref/src/sys/dev/i2c/ibmhawk.c#96>
 I found three more, and apparently I=E2=80=99m the idiot responsible for =
 all three of them. Checked in fixes for titemp, tcakp, and act8846pm.
 
 
 
 --Apple-Mail=_4FA40B50-3E1E-4320-993F-8BB7A77FD40B
 Content-Transfer-Encoding: quoted-printable
 Content-Type: text/html;
 	charset=utf-8
 
 <html><head><meta http-equiv=3D"Content-Type" content=3D"text/html; =
 charset=3Dutf-8"></head><body style=3D"word-wrap: break-word; =
 -webkit-nbsp-mode: space; line-break: after-white-space;" class=3D"">On =
 Apr 30, 2018, at 5:21 PM, Jared McNeill &lt;<a =
 href=3D"mailto:jmcneill%invisible.ca@localhost"; =
 class=3D"">jmcneill%invisible.ca@localhost</a>&gt; wrote:<br =
 class=3D""><div><blockquote type=3D"cite" class=3D""><br =
 class=3D"Apple-interchange-newline"><div class=3D""><meta =
 http-equiv=3D"Content-Type" content=3D"text/html; charset=3Dutf-8" =
 class=3D""><div style=3D"word-wrap: break-word; -webkit-nbsp-mode: =
 space; line-break: after-white-space;" class=3D""><br class=3D""><div =
 class=3D""><blockquote type=3D"cite" class=3D""><div class=3D"">On Apr =
 30, 2018, at 5:16 PM, Jared McNeill &lt;<a =
 href=3D"mailto:jmcneill%invisible.ca@localhost"; =
 class=3D"">jmcneill%invisible.ca@localhost</a>&gt; wrote:</div><br =
 class=3D"Apple-interchange-newline"><div class=3D""><span =
 style=3D"caret-color: rgb(0, 0, 0); font-family: Helvetica; font-size: =
 12px; font-style: normal; font-variant-caps: normal; font-weight: =
 normal; letter-spacing: normal; text-align: start; text-indent: 0px; =
 text-transform: none; white-space: normal; word-spacing: 0px; =
 -webkit-text-stroke-width: 0px; text-decoration: none; float: none; =
 display: inline !important;" class=3D"">I thought we had some drivers =
 that relied on this but when I went to look I couldn=E2=80=99t find =
 any..</span><br style=3D"caret-color: rgb(0, 0, 0); font-family: =
 Helvetica; font-size: 12px; font-style: normal; font-variant-caps: =
 normal; font-weight: normal; letter-spacing: normal; text-align: start; =
 text-indent: 0px; text-transform: none; white-space: normal; =
 word-spacing: 0px; -webkit-text-stroke-width: 0px; text-decoration: =
 none;" class=3D""></div></blockquote></div><br class=3D""><div =
 class=3D"">Ok I found one! It=E2=80=99s clearly broken..</div><div =
 class=3D""><br class=3D""></div><div class=3D""><a =
 href=3D"https://nxr.netbsd.org/xref/src/sys/dev/i2c/ibmhawk.c#96"; =
 class=3D"">https://nxr.netbsd.org/xref/src/sys/dev/i2c/ibmhawk.c#96</a></d=
 iv></div></div></blockquote><br class=3D""></div><div>I found three =
 more, and apparently I=E2=80=99m the idiot responsible for all three of =
 them. Checked in fixes for titemp, tcakp, and&nbsp;<span =
 style=3D"white-space: pre-wrap; background-color: rgb(255, 255, 255);" =
 class=3D"">act8846pm.</span></div><div class=3D""><br class=3D""></div><br=
  class=3D""></body></html>=
 
 --Apple-Mail=_4FA40B50-3E1E-4320-993F-8BB7A77FD40B--
Home | Main Index | Thread Index | Old Index