Re: port-arm/53171 (Broadcom (and other ARM SoC i2c drivers) mis-handle indirect configuration of devices)

[Jason Thorpe <thorpej%me.com@localhost>]

The following reply was made to PR port-arm/53171; it has been noted by GNATS.

From: Jason Thorpe <thorpej%me.com@localhost>
To: Jared McNeill <jmcneill%invisible.ca@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, Jason Thorpe <thorpej%NetBSD.org@localhost>,
 port-arm-maintainer%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, gnats-admin%netbsd.org@localhost
Subject: Re: port-arm/53171 (Broadcom (and other ARM SoC i2c drivers)
 mis-handle indirect configuration of devices)
Date: Mon, 30 Apr 2018 19:12:31 -0700

 > On Apr 30, 2018, at 1:38 PM, Jared McNeill <jmcneill%invisible.ca@localhost> =
 wrote:
 >=20
 > On Apr 30, 2018, at 5:21 PM, Jared McNeill <jmcneill%invisible.ca@localhost> =
 wrote:
 >>=20
 >>=20
 >>> On Apr 30, 2018, at 5:16 PM, Jared McNeill <jmcneill%invisible.ca@localhost> =
 wrote:
 >>>=20
 >>> I thought we had some drivers that relied on this but when I went to =
 look I couldn=E2=80=99t find any..
 >>=20
 >> Ok I found one! It=E2=80=99s clearly broken..
 >>=20
 >> https://nxr.netbsd.org/xref/src/sys/dev/i2c/ibmhawk.c#96
 >=20
 > I found three more, and apparently I=E2=80=99m the idiot responsible =
 for all three of them. Checked in fixes for titemp, tcakp, and =
 act8846pm.
 
 Hey man, I wasn=E2=80=99t going to say anything=E2=80=A6 :-)
 
 Anyway, I double-checked, and iic_search() already disallows =
 IICCF_ADDR_DEFAULT, so that=E2=80=99s good.  =E2=80=9Cibmhawk=E2=80=9D =
 is particularly egregious.  It looks like it=E2=80=99s expected at 0x37, =
 so we can filter it out there, I suppose.  It would be even better if =
 there were an ACPI node for it, or something.
 
 (Speaking of ACPI =E2=80=94 geez, that thing is just crying out to be =
 converted to FDT at run-time :-) )
 
 >=20
 >=20
 
 -- thorpej