Re: kern/53217: -current: dumping to wedges on GPT disks broken

[mlelstv%serpens.de@localhost (Michael van Elst)]

The following reply was made to PR kern/53217; it has been noted by GNATS.

From: mlelstv%serpens.de@localhost (Michael van Elst)
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/53217: -current: dumping to wedges on GPT disks broken
Date: Fri, 27 Apr 2018 16:04:07 -0000 (UTC)

 martin%duskware.de@localhost (Martin Husemann) writes:
 
 > >  In dksubr.c dkdump (not the wedge code, the general disk support) then 
 > >  examines as I quoted
 > >        796         /* Convert to disk sectors.  Request must be a 
 > >  multiple of size. */
 > >       797         part = DISKPART(dev);
 > >  ...
 > >       806         p = &lp->d_partitions[part];
 > 
 > And here accessing the label at all is clearly a bug.
 
 
 There is more to do, as the dump address / size is checked against
 the partition size.
 
 -- 
 -- 
                                 Michael van Elst
 Internet: mlelstv%serpens.de@localhost
                                 "A potential Snark may lurk in every tree."