Re: port-mips/52892: Tests hang on MIPS

[Andreas Gustafsson <gson%gson.org@localhost>]

The following reply was made to PR port-mips/52892; it has been noted by GNATS.

From: Andreas Gustafsson <gson%gson.org@localhost>
To: christos%zoulas.com@localhost (Christos Zoulas)
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: port-mips/52892: Tests hang on MIPS
Date: Sun, 22 Apr 2018 17:29:13 +0300

 Christos Zoulas wrote:
 > Can you try to always set errno to EAGAIN after cv_wait_sig()
 > returns?
 
 My other method of reproducing the hang took a bit longer than
 expected, so in the meantime, I ended up running this test as
 requested after all.  I applied the following patch to
 2018.04.20.11.31.54 sources:
 
 --- src/sys/kern/kern_lwp.c.orig	2017-12-02 22:51:22.000000000 +0000
 +++ src/sys/kern/kern_lwp.c	2018-04-22 14:19:14.000000000 +0000
 @@ -646,8 +646,7 @@
  		if (exiting) {
  			KASSERT(p->p_nlwps > 1);
  			error = cv_wait_sig(&p->p_lwpcv, p->p_lock);
 -			if (error == 0)
 -				error = EAGAIN;
 +			error = EAGAIN;
  			break;
  		}
  
 With this patch, the hang still occurs, so it looks like the problem
 is with the part of kern_lwp.c 1.191 that replaces cv_wait() by
 cv_wait_sig(), not the part that changes the errno returned.
 -- 
 Andreas Gustafsson, gson%gson.org@localhost