bin/53071: some atf tests fail on NFS in cleanup

[uwe%NetBSD.org@localhost]

>Number:         53071
>Category:       bin
>Synopsis:       some atf tests fail on NFS in cleanup
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 04 11:10:00 +0000 2018
>Originator:     Valery Ushakov
>Release:        current 2018-03-04
>Organization:
>Environment:
>Description:
On a diskless system run e.g.

$ cd /usr/tests/dev/raidframe && atf-run
[...]
tps-count: 1
tp-start: 1520160924.105161, t_raid, 7
tc-start: 1520160924.106797, old_numrows_config
tc-so:Executing command [ rump_server -lrumpvfs -lrumpdev -lrumpdev_disk -lrumpdev_raidframe -d key=/disk0,hostpath=disk0.img,size=1m -d key=/disk1,hostpath=disk1.img,size=1m unix://sock ]
tc-so:Executing command [ rump.raidctl -C raid.conf raid0 ]
tc-end: 1520160927.931706, old_numrows_config, passed
atf-run: ERROR: tools::fs::rmdir: Cannot remove directory: Directory not
atf-run: empty

What happens is that something is still holding files open when test cleanup tries to remove the directory with them.  Since this is on an NFS, the files are NOT removed silently, but instead become renamed to .nfsXXXXXXXX and the directory cannot be removed.  Running ls -l in a loop on the NFS server I can see:


atf-run.M0aymz:
total 4
-rw-r--r--  1 root  wheel  7 Mar  4 14:05 tcr
atf-run.BNvgJ0:
total 100
-rw-r--r--  1 root  wheel  1048576 Mar  4 14:05 disk0.img
-rw-r--r--  1 root  wheel  1048576 Mar  4 14:05 disk1.img
-rw-r--r--  1 root  wheel       87 Mar  4 14:05 raid.conf
srwxr-xr-x  1 root  wheel        0 Mar  4 14:05 sock

atf-run.M0aymz:
total 4
-rw-r--r--  1 root  wheel  7 Mar  4 14:05 tcr
atf-run.BNvgJ0:
total 100
srwxr-xr-x  1 root  wheel        0 Mar  4 14:05 .nfsA41134.4
-rw-r--r--  1 root  wheel  1048576 Mar  4 14:05 disk0.img
-rw-r--r--  1 root  wheel  1048576 Mar  4 14:05 disk1.img
-rw-r--r--  1 root  wheel       87 Mar  4 14:05 raid.conf

[...]

atf-run.M0aymz:
atf-run.BNvgJ0:
total 0
srwxr-xr-x  1 root  wheel  0 Mar  4 14:05 .nfsA41134.4

>How-To-Repeat:

>Fix: