[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/44059 CVS commit: src/sys/dist/pf/net
The following reply was made to PR kern/44059; it has been noted by GNATS.
From: "Maxime Villard" <maxv%netbsd.org@localhost>
Subject: PR/44059 CVS commit: src/sys/dist/pf/net
Date: Fri, 9 Feb 2018 21:25:04 +0000
Module Name: src
Committed By: maxv
Date: Fri Feb 9 21:25:04 UTC 2018
Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.
It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
This bug was reported 8 years ago by Lucio Albornoz in PR/44059.
To generate a diff of this commit:
cvs rdiff -u -r1.77 -r1.78 src/sys/dist/pf/net/pf.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Main Index |
Thread Index |