NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

re: port-amd64/52964: src/sys/arch/amd64/amd64/db_interface.c:241: suspicous coding ?



The following reply was made to PR port-amd64/52964; it has been noted by GNATS.

From: matthew green <mrg%eterna.com.au@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: port-amd64-maintainer%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
    netbsd-bugs%netbsd.org@localhost
Subject: re: port-amd64/52964: src/sys/arch/amd64/amd64/db_interface.c:241: suspicous coding ?
Date: Wed, 31 Jan 2018 11:59:57 +1100

 > src/sys/arch/amd64/amd64/db_interface.c:241]: (warning) Address of local=
  variable dbreg is assigned to global pointer ddb_regp and not reassigned =
 before dbre
 > g goes out of scope.
 > =
 
 > Source code is
 > =
 
 >     ddb_regp =3D &dbreg;
 > =
 
 > Surely dangerous to export the address of a local variable outside the
 > scope of the function ?
 
 this line should asssign NULL.  looks like a copy pasto.
 
 
 .mrg.
 


Home | Main Index | Thread Index | Old Index