Re: misc/52886: Tests hang at pk2_ffs_*

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2018/01/09 10:40, maya%netbsd.org@localhost wrote:
> The following reply was made to PR misc/52886; it has been noted by GNATS.
>
> From: maya%netbsd.org@localhost
> To: gnats-bugs%netbsd.org@localhost
> Cc:
> Subject: Re: misc/52886: Tests hang at pk2_ffs_*
> Date: Tue, 9 Jan 2018 01:38:53 +0000
>
>   Does this help (not built tested)
>   
>   Index: ./librump/rumpkern/rump.c
>   ===================================================================
>   RCS file: /cvsroot/src/sys/rump/librump/rumpkern/rump.c,v
>   retrieving revision 1.330
>   diff -u -r1.330 rump.c
>   --- ./librump/rumpkern/rump.c	21 Nov 2017 08:49:14 -0000	1.330
>   +++ ./librump/rumpkern/rump.c	9 Jan 2018 01:38:05 -0000
>   @@ -388,6 +388,7 @@
>    		aprint_verbose("cpu%d at thinair0: rump virtual cpu\n", i);
>    	}
>    	ncpuonline = ncpu;
>   +	mp_online = true;
>    
>    	/* Once all CPUs are detected, initialize the per-CPU cprng_fast.  */
>    	cprng_fast_init();
>   

The location is not good. At least, mp_online = true must be called after
cprng_fast_init() to avoid some test fails. The calling order's difference
between init_main.c::main() and rump.c::rump_init() is big and I don't know
where is the best location.

--
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)