Re: kern/52899: Kernel panic with iwm

[Alexander Nasonov <alnsn%yandex.ru@localhost>]

The following reply was made to PR kern/52899; it has been noted by GNATS.

From: Alexander Nasonov <alnsn%yandex.ru@localhost>
To: Christos Zoulas <christos%zoulas.com@localhost>
Cc: Alexander Nasonov <alnsn%yandex.ru@localhost>, gnats-bugs%NetBSD.org@localhost,
	kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
	netbsd-bugs%netbsd.org@localhost, dogan%tesmer.org.tr@localhost
Subject: Re: kern/52899: Kernel panic with iwm
Date: Sat, 6 Jan 2018 22:49:08 +0000

 Christos Zoulas wrote:
 > Does this fix it?
 
 No, it doesn't fix it. Because you omitted the ifp definition in your patch,
 below is the change I tested:
 
  iwm_preinit(struct iwm_softc *sc)
  {
         struct ieee80211com *ic = &sc->sc_ic;
 +       struct ifnet *ifp = &sc->sc_ec.ec_if;
         int err;
 
         if (ISSET(sc->sc_flags, IWM_FLAG_ATTACHED))
 @@ -7758,6 +7759,7 @@ iwm_preinit(struct iwm_softc *sc)
         if (sc->sc_nvm.sku_cap_band_52GHz_enable)
                 ic->ic_sup_rates[IEEE80211_MODE_11A] = ieee80211_std_rateset_11a;
 
 +       ether_ifdetach(ifp);
         ieee80211_ifattach(ic);
 
         ic->ic_node_alloc = iwm_node_alloc;
 
 -- 
 Alex