Re: kern/52643: npfctl reload on rump kernels fails randomly

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR kern/52643; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: Ryota Ozaki <ozaki-r%netbsd.org@localhost>, 
	"gnats-bugs%NetBSD.org@localhost" <gnats-bugs%netbsd.org@localhost>
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
	netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/52643: npfctl reload on rump kernels fails randomly
Date: Fri, 27 Oct 2017 07:28:20 -0400

 On Oct 27, 12:41pm, ozaki-r%netbsd.org@localhost (Ryota Ozaki) wrote:
 -- Subject: Re: kern/52643: npfctl reload on rump kernels fails randomly
 
 | Further investigations found the following requirements:
 | - prop_object_release(errdict) must be always called
 |   because errdict = prop_dictionary_create() is always called
 | - prop_object_release(npf_dict) needs to be called only if
 |   npf_dict is allocated by prop_dictionary_copyin_ioctl_size
 | - _NPF_STANDALONE doesn't require to set prop
 | - For _NPF_TESTING, if npfctl_testing, setting prop isn't
 |   needed, otherwise it's needed
 | 
 | So I think a fix looks like the following patch. Comments?
 
 Go for it, add the big fat comment above to the patch though :-)
 
 christos