misc/52650: /etc/rc.d/SERVERS should not REQUIRE mountcritremote

[jlam%NetBSD.org@localhost]

>Number:         52650
>Category:       misc
>Synopsis:       /etc/rc.d/SERVERS should not REQUIRE mountcritremote
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 24 14:25:00 +0000 2017
>Originator:     Johnny C. Lam
>Release:        NetBSD 7.1_STABLE
>Organization:
>Environment:
System: NetBSD sasha.home 7.1_STABLE NetBSD 7.1_STABLE (THINKCENTRE_C30) #6: Wed Aug 9 21:12:13 EDT 2017 sysbuild%sasha.home@localhost:/home/sysbuild/netbsd-7/amd64/obj/home/sysbuild/netbsd-7/src/sys/arch/amd64/compile/THINKCENTRE_C30 amd64
Architecture: x86_64
Machine: amd64
>Description:
	The /etc/rc.d scripts that are all-caps are "barrier"
	scripts, which are used as dummy dependencies for actual
	rc.d scripts.  As such, they should not contain a REQUIRE
	line that lists a non-barrier scripts.

	The original discussion on tech-userlevel on March 2002
	was about reversing the direction of the dependencies in
	the barrier scripts.  Originally, for example, the DAEMON
	script required a lot of other scripts, but the /etc/rc
	threw errors if any of those required scripts were
	removed.

	The commit by <thorpej> changed "a REQUIRE b" to
	"b BEFORE a" if "a" was a barrier script, so that the
	barrier scripts weren't as fragile if other scripts were
	removed.  However, for some reason, the only such change
	that wasn't made was "SERVER REQUIRE mountcritremote",
	which remained when all other such dependencies were
	changed.
		

>How-To-Repeat:
	# cd /etc/rc.d && rcorder [A-Z]*
	rcorder: requirement `mountcritremote' in file `SERVERS' has no providers.
	SERVERS
	NETWORKING
	DAEMON
	LOGIN
	DISKS
>Fix:
	/etc/rc.d/SERVERS should lose the line that says:
		# REQUIRE: mountcritremote

	/etc/rc.d/mountcritremote should include a new line that says:
		# BEFORE: SERVERS