lib/52649: fish shell doesn't work well with netbsd libraries and needs ncurses

[coypu%sdf.org@localhost]

>Number:         52649
>Category:       lib
>Synopsis:       fish shell doesn't work well with netbsd libraries and needs ncurses
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Oct 24 10:40:00 +0000 2017
>Originator:     coypu
>Release:        NetBSD 8.99.4
>Organization:
>Environment:
NetBSD localhost 8.99.4 NetBSD 8.99.4 (GENERIC) #3: Sun Oct 22 03:14:21 IDT 2017  fly@localhost:/home/fly/obj/sys/arch/amd64/compile/GENERIC amd64

>Description:
Auto completion with fish and netbsd curses/terminfo doesn't work correctly, it's displayed broken.
Since fish always tries to display auto-completion, it always appears broken.

It looks like it's failing to set the cursor to the beginning of the prompt (?)

There are some patches which may affect it in pkgsrc/shells/fish/patches/, I didn't write them.
>How-To-Repeat:
to build fish with netbsd curses (I forced it to use ncurses so the package works), apply the following patch:

===================================================================
RCS file: /cvsroot/pkgsrc/shells/fish/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- Makefile	24 Oct 2017 03:51:41 -0000	1.12
+++ Makefile	24 Oct 2017 10:32:58 -0000
@@ -14,7 +14,6 @@
 
 USE_LANGUAGES+=		c c++
 GNU_CONFIGURE=		yes
-USE_NCURSES=		yes
 CONFIGURE_ARGS+=	--sysconfdir=${PKG_SYSCONFDIR}
 CONFIGURE_ARGS+=	--without-xsel
 USE_TOOLS+=		gmake autoreconf autoconf automake
@@ -51,5 +50,5 @@
 .include "../../devel/gettext-tools/buildlink3.mk"
 .include "../../lang/python/application.mk"
 # Broken auto completion with netbsd curses
-.include "../../devel/ncurses/buildlink3.mk"
+.include "../../mk/curses.buildlink3.mk"
 .include "../../mk/bsd.pkg.mk"

>Fix: