kern/52360: LFS can crash DEBUG kernel around lfs_vnops.c line 1658

[Shinichi Doyashiki <clare%csel.org@localhost>]

>Number:         52360
>Category:       kern
>Synopsis:       LFS can crash DEBUG kernel around lfs_vnops.c line 1658
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jul 02 14:25:00 +0000 2017
>Originator:     Shinichi Doyashiki
>Release:        NetBSD 8.99.1
>Organization:
	at home
>Environment:
System: NetBSD kanako.csel.org 8.99.1 NetBSD 8.99.1 (KANAKO) #9: Sun Jul 2 19:14:05 JST 2017 clare%kanako.csel.org@localhost:/export/stage/hack/sys/arch/amd64/compile/KANAKO amd64
Architecture: x86_64
Machine: amd64
>Description:
	LFS can crash DEBUG kernel as following:

panic: kernel diagnostic assertion "(ip->i_state & IN_ADIROP) == 0" failed: file "../../../../ufs/lfs/lfs_vnops.c
", line 1658

# gdb /export/stage/hack/sys/arch/amd64/compile/KANAKO/netbsd.gdb
GNU gdb (GDB) 7.12
Copyright (C) 2016 Free Software Foundation, Inc.
License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>
This is free software: you are free to change and redistribute it.
There is NO WARRANTY, to the extent permitted by law.  Type "show copying"
and "show warranty" for details.
This GDB was configured as "x86_64--netbsd".
Type "show configuration" for configuration details.
For bug reporting instructions, please see:
<http://www.gnu.org/software/gdb/bugs/>.
Find the GDB manual and other documentation resources online at:
<http://www.gnu.org/software/gdb/documentation/>.
For help, type "help".
Type "apropos word" to search for commands related to "word"...
Reading symbols from /export/stage/hack/sys/arch/amd64/compile/KANAKO/netbsd.gdb...done.
(gdb) target kvm netbsd.3.core
0xffffffff80229545 in cpu_reboot (howto=howto@entry=260, bootstr=bootstr@entry=0x0)
    at ../../../../arch/amd64/amd64/machdep.c:674
674                     dumpsys();
(gdb) bt
#0  0xffffffff80229545 in cpu_reboot (howto=howto@entry=260, bootstr=bootstr@entry=0x0)
    at ../../../../arch/amd64/amd64/machdep.c:674
#1  0xffffffff808fddac in vpanic (
    fmt=0xffffffff80e46fa0 "kernel %sassertion \"%s\" failed: file \"%s\", line %d ",
    ap=ap@entry=0xffffe4010f25da58) at ../../../../kern/subr_prf.c:342
#2  0xffffffff80b18585 in kern_assert (
    fmt=fmt@entry=0xffffffff80e46fa0 "kernel %sassertion \"%s\" failed: file \"%s\", line %d ")
    at ../../../../../../lib/libkern/kern_assert.c:51
#3  0xffffffff80853fad in lfs_flush_dirops (fs=fs@entry=0xffffe40228280008)
    at ../../../../ufs/lfs/lfs_vnops.c:1658
#4  0xffffffff808333d7 in lfs_check (vp=vp@entry=0xffffe40199b86540, blkno=blkno@entry=-1, flags=flags@entry=0)
    at ../../../../ufs/lfs/lfs_bio.c:658
#5  0xffffffff808523c1 in lfs_set_dirop (dvp=dvp@entry=0xffffe40199b86540, vp=vp@entry=0x0)
    at ../../../../ufs/lfs/lfs_vnops.c:580
#6  0xffffffff8085307e in lfs_create (v=0xffffe4010f25dbc8) at ../../../../ufs/lfs/lfs_vnops.c:893
#7  0xffffffff80961e5e in VOP_CREATE (dvp=0xffffe40199b86540, vpp=vpp@entry=0xffffe4010f25dd80,
    cnp=cnp@entry=0xffffe4010f25dda8, vap=vap@entry=0xffffe4010f25dc30) at ../../../../kern/vnode_if.c:216
#8  0xffffffff8095a26c in vn_open (ndp=ndp@entry=0xffffe4010f25dd58, fmode=fmode@entry=1539,
    cmode=cmode@entry=420) at ../../../../kern/vfs_vnops.c:211
#9  0xffffffff80951154 in do_open (l=l@entry=0xffffe401cc949940, dvp=0x0, pb=<optimized out>,
    open_flags=open_flags@entry=1538, open_mode=open_mode@entry=438, fd=fd@entry=0xffffe4010f25de7c)
    at ../../../../kern/vfs_syscalls.c:1576
#10 0xffffffff809512a5 in do_sys_openat (l=0xffffe401cc949940, fdat=fdat@entry=-100, path=<optimized out>,
    flags=1538, mode=438, fd=fd@entry=0xffffe4010f25de7c) at ../../../../kern/vfs_syscalls.c:1656
#11 0xffffffff80951363 in sys_open (l=<optimized out>, uap=<optimized out>, retval=0xffffe4010f25deb0)
    at ../../../../kern/vfs_syscalls.c:1676
#12 0xffffffff8024f60d in sy_call (rval=0xffffe4010f25deb0, uap=0xffffe4010f25df00, l=0xffffe401cc949940,
    sy=0xffffffff81275658 <sysent+120>) at ../../../../sys/syscallvar.h:65
#13 sy_invoke (code=5, rval=0xffffe4010f25deb0, uap=0xffffe4010f25df00, l=0xffffe401cc949940,
    sy=0xffffffff81275658 <sysent+120>) at ../../../../sys/syscallvar.h:94
#14 syscall (frame=0xffffe4010f25df00) at ../../../../arch/x86/x86/syscall.c:144
#15 0xffffffff80200771 in Xsyscall ()

>How-To-Repeat:
	1. prepare LFS32 filesystem for objdir
	2. run build.sh -j8
>Fix:
	unknown