bin/52283: postinstall is out of date (and related issues)

[kre%munnari.OZ.AU@localhost]

>Number:         52283
>Category:       bin
>Synopsis:       postinstall is out of date (and related issues)
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jun 08 12:35:00 +0000 2017
>Originator:     Robert Elz
>Release:        NetBSD 7.1_STABLE
>Organization:
>Environment:
System: NetBSD munnari.OZ.AU 7.1_STABLE NetBSD 7.1_STABLE (MUNNARI-DomU) #28: Fri Mar 24 10:31:59 ICT 2017 kre%onyx.coe.psu.ac.th@localhost:/usr/obj/7/kernels/amd64/MUNNARI-DomU amd64
Architecture: x86_64
Machine: amd64
>Description:
	postinstall does not seem to have been updated to match reality.

	When I run it as ...

		 postinstall -s /usr/src -d / check

	One of its complaints is...

		motd check:
		eval: cannot open /usr/src/etc/motd: no such file
			Bug reporting messages do not seem to match the installed release

	This is not surprising, as there is no /usr/src/etc/motd any more, rather
	there are motd.{beta,current,default,rc,stable} instead.

	It also complains
		fontconfig check:
			/usr/src/../xsrc/external/mit/fontconfig/dist/conf.d is not a directory; skipping check

	also not surprising, as I have "xsrc" as a sub-dir of "src" not a sibling
	(it, and pkgsrc, are source directories, they belong in /usr/src not /usr)
	EVerything else handles this config OK (build.sh gets told where XSRC is
	located, it should implant that knowledge in postinstall).

	And another
		dhcpcd check:
			/var/db/dhcpcd is not a directory
	This one not necessarily a postinstall problem, /var/db/dhcpcd does not
	exist.  But why not?   The system in question was just built by "build.sh distribution"
	and then booted (with absolutely minimal extra config) - if /var/db/dhcpcd is
	supposed to exist, why is build.sh not creating it?  (Something missing in the
	mtree file?)

>How-To-Repeat:
	Build a new system into an empty filesystem, boot it, run postinstall ...

>Fix:
	N/A    (until it was the finder of PR bin/52280 the other day, I had never
		used postinstall before, ever ... had no idea how.   Now I think I
		was never missing anything...)

>Unformatted:
 	(this is irrelevant, the system where I am running send-pr, where I am
 	running postinstall has no configured mailer, and no useful configured network)