NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

port-xen/52112: arch/xen/xenbus/xenbus_dev.c:400: pointless assignment in critical section



>Number:         52112
>Category:       port-xen
>Synopsis:       arch/xen/xenbus/xenbus_dev.c:400: pointless assignment in critical section
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-xen-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Mar 27 16:05:00 +0000 2017
>Originator:     David Binderman
>Release:        cvs-20170327
>Organization:
>Environment:
>Description:
src/sys/arch/xen/xenbus/xenbus_dev.c:395] -> [src/sys/arch/xen/xenbus/xenbus_dev.c:400]: (style) Variable 'u' is reassigned a value before the old one has been used.

Source code is

    struct xenbus_dev_data *u = kfs->kfs_v;
    struct xenbus_dev_lwp *xlwp;
    struct xenbus_dev_transaction *trans;

    mutex_enter(&xenbus_dev_open_mtx);
    u = kfs->kfs_v;

Second assignment looks pointless. Suggest remove. 
>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index