Re: kern/51999 pulseaudio broken

[Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>]

The following reply was made to PR kern/51999; it has been noted by GNATS.

From: Ryo ONODERA <ryo_on%yk.rim.or.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost, nat%netbsd.org@localhost
Cc: 
Subject: Re: kern/51999 pulseaudio broken
Date: Thu, 23 Mar 2017 21:16:34 +0900 (JST)

 Hi,
 
 Your patch fixes audio playback from pkgsrc/multimedia/mplayer
 and pkgsrc/www/firefox via pkgsrc/audio/pulseaudio.
 
 Thank you very much.
 
 From: Nathanial Sloss <nat%netbsd.org@localhost>, Date: Thu, 23 Mar 2017 11:00:01 +0000 (UTC)
 
 > The following reply was made to PR kern/51999; it has been noted by GNATS.
 > 
 > From: Nathanial Sloss <nat%netbsd.org@localhost>
 > To: gnats-bugs%netbsd.org@localhost
 > Cc: 
 > Subject: Re: kern/51999 pulseaudio broken
 > Date: Thu, 23 Mar 2017 21:55:59 +1100
 > 
 >  With this patch to liboss playback and recording with pulseaudio work.
 >  
 >  --- src/lib/libossaudio/ossaudio.c	2017-02-11 05:16:31.000000000 +1100
 >  +++ /home/netbsd/ossaudio.c	2017-03-23 21:51:14.000000000 +1100
 >  @@ -411,11 +411,11 @@ audio_ioctl(int fd, unsigned long com, v
 >   			return retval;
 >   		setblocksize(fd, &tmpinfo);
 >   		bufinfo.fragsize = tmpinfo.blocksize;
 >  -		bufinfo.fragments = tmpinfo.hiwat - (tmpinfo.play.seek
 >  -		    + tmpinfo.blocksize - 1) / tmpinfo.blocksize;
 >  +		bufinfo.fragments = (tmpinfo.hiwat * tmpinfo.blocksize - (
 >  +		    tmpinfo.play.seek + tmpinfo.blocksize -1)) /
 >  +		    tmpinfo.blocksize;
 >   		bufinfo.fragstotal = tmpinfo.hiwat;
 >  -		bufinfo.bytes = tmpinfo.hiwat * tmpinfo.blocksize
 >  -		    - tmpinfo.play.seek;
 >  +		bufinfo.bytes = bufinfo.fragments * tmpinfo.blocksize;
 >   		*(struct audio_buf_info *)argp = bufinfo;
 >   		break;
 >   	case SNDCTL_DSP_GETISPACE:
 >  @@ -424,11 +424,10 @@ audio_ioctl(int fd, unsigned long com, v
 >   			return retval;
 >   		setblocksize(fd, &tmpinfo);
 >   		bufinfo.fragsize = tmpinfo.blocksize;
 >  -		bufinfo.fragments = tmpinfo.hiwat - (tmpinfo.record.seek +
 >  -		    tmpinfo.blocksize - 1) / tmpinfo.blocksize;
 >  +		bufinfo.fragments = (tmpinfo.record.seek)
 >  +		    / tmpinfo.blocksize;
 >   		bufinfo.fragstotal = tmpinfo.hiwat;
 >  -		bufinfo.bytes = tmpinfo.hiwat * tmpinfo.blocksize
 >  -		    - tmpinfo.record.seek;
 >  +		bufinfo.bytes = bufinfo.fragments * tmpinfo.blocksize;
 >   		*(struct audio_buf_info *)argp = bufinfo;
 >   		break;
 >   	case SNDCTL_DSP_NONBLOCK:
 >  
 >  
 >  Best regards,
 >  
 >  Nat
 >  
 
 --
 Ryo ONODERA // ryo_on%yk.rim.or.jp@localhost
 PGP fingerprint = 82A2 DC91 76E0 A10A 8ABB  FD1B F404 27FA C7D1 15F3