toolchain/52089: Change the effect of "make clean" slightly

[kre%munnari.OZ.AU@localhost]

>Number:         52089
>Category:       toolchain
>Synopsis:       Change the effect of "make clean" slightly
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    toolchain-manager
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 19 03:05:00 +0000 2017
>Originator:     Robert Elz
>Release:        NetBSD 7.99.65 (irrelevant, applies to all)
>Organization:
>Environment:
	
	
System: NetBSD andromeda.noi.kre.to 7.99.43 NetBSD 7.99.43 (VBOX64-1.2-20161202) #21: Sat Dec 3 00:43:51 ICT 2016 kre%magnolia.noi.kre.to@localhost:/usr/obj/current/kernels/amd64/VBOX64 amd64
Architecture: x86_64
Machine: amd64
>Description:
	Currently "make clean" does not clean all files generated by
	"make" - "make distclean" is needed to remove some of them.
	(In particular, generated man page files)

	It would be better to have "make clean" remove everything added
	by "make", and "make distclean" clean that, plus the files added
	by "make depend", that's more consistent, and easier to
	understand.

>How-To-Repeat:
	By inspection, or just by using the commands.

>Fix:
	This is untested, but I assume it would be something like ...

--- bsd.man.mk	2015-10-20 00:08:11.000000000 +0700
+++ bsd.man.mk-better-clean	2017-03-19 09:59:39.000000000 +0700
@@ -277,13 +277,13 @@
 
 .if !empty(MAN) && (${MKMAN} != "no")
 .if (${MKCATPAGES} != "no")
-CLEANDIRFILES+= ${CATPAGES}
+CLEANFILES+= ${CATPAGES}
 .endif
 .if !empty(MANSUFFIX)
-CLEANDIRFILES+= ${MANPAGES} ${CATPAGES:S/${MANSUFFIX}$//}
+CLEANFILES+= ${MANPAGES} ${CATPAGES:S/${MANSUFFIX}$//}
 .endif
 .if ${MKHTML} != "no"
-CLEANDIRFILES+= ${HTMLPAGES}
+CLEANFILES+= ${HTMLPAGES}
 .endif
 .endif
 # (XXX ${CATPAGES:S...} cleans up old .catN files where .catN.gz now used)