Re: kern/52023: bpf kassert: !cpu_intr_p()

[coypu%SDF.ORG@localhost]

The following reply was made to PR kern/52023; it has been noted by GNATS.

From: coypu%SDF.ORG@localhost
To: gnats-bugs%netbsd.org@localhost
Cc: martin%netbsd.org@localhost
Subject: Re: kern/52023: bpf kassert: !cpu_intr_p()
Date: Thu, 2 Mar 2017 21:05:18 +0000

 --zgody6llazldu6xm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 http://mail-index.netbsd.org/current-users/2017/02/17/msg031142.html
 
 --zgody6llazldu6xm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="shark.diff"
 
 Index: cs89x0.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/ic/cs89x0.c,v
 retrieving revision 1.38
 diff -u -p -u -r1.38 cs89x0.c
 --- cs89x0.c	15 Dec 2016 09:28:05 -0000	1.38
 +++ cs89x0.c	2 Mar 2017 20:59:16 -0000
 @@ -486,6 +486,7 @@ cs_attach(struct cs_softc *sc, u_int8_t 
  
  	/* Attach the interface. */
  	if_attach(ifp);
 +	if_deferred_start_init(ifp, NULL);
  	ether_ifattach(ifp, sc->sc_enaddr);
  
  	rnd_attach_source(&sc->rnd_source, device_xname(sc->sc_dev),
 @@ -1583,11 +1584,8 @@ cs_transmit_event(struct cs_softc *sc, u
  	/* Transmission is no longer in progress */
  	sc->sc_txbusy = FALSE;
  
 -	/* If there is more to transmit */
 -	if (IFQ_IS_EMPTY(&ifp->if_snd) == 0) {
 -		/* Start the next transmission */
 -		cs_start_output(ifp);
 -	}
 +	/* Maybe there is more to transmit */
 +	if_schedule_deferred_start(ifp);
  }
  
  void
 
 --zgody6llazldu6xm--