NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

bin/51804: Fix up #includes in tests/lib/libc/c063/...

>Number:         51804
>Category:       bin
>Synopsis:       Fix up #includes in tests/lib/libc/c063/...
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 10 08:40:00 +0000 2017
>Originator:     Ngie Cooper
>Release:        7.0.2-RELEASE
Several of the tests/lib/libc/c063/... test cases require function definitions/macros in sys/stat.h which trip up FreeBSD when building the test cases. It works by accident on NetBSD via header pollution (FreeBSD, NetBSD, and POSIX all state that the headers are required for building with the macros/functions).

The attached patch does 2 things:
- Sorts sys/ headers before non-sys headers (it's a style(9) thing on FreeBSD, but it also makes the code a bit more portable if ported to other operating systems).
- Adds sys/stat.h #include.

Patch coming soon.


Home | Main Index | Thread Index | Old Index