NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/51672: src/sys/arch/x86/pci/if_vmx.c:2555: suspicious bit mask ?



>Number:         51672
>Category:       kern
>Synopsis:       src/sys/arch/x86/pci/if_vmx.c:2555: suspicious bit mask ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Nov 29 10:20:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs-20161129
>Organization:
>Environment:
>Description:
[src/sys/arch/x86/pci/if_vmx.c:2555]: (style) Same expression on both sides of '|'.

Source code is

    if (m->m_pkthdr.csum_flags &
        (M_CSUM_TCPv4 | M_CSUM_TCPv4 | M_CSUM_TSOv4 | M_CSUM_TSOv6)) {

Maybe

    if (m->m_pkthdr.csum_flags &
        (M_CSUM_TCPv4 | M_CSUM_TCPv6 | M_CSUM_TSOv4 | M_CSUM_TSOv6)) {

was intended ?
>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index