PR/51633 CVS commit: src/tests/lib/libpthread_dbg

["Kamil Rytarowski" <kamil%netbsd.org@localhost>]

The following reply was made to PR lib/51633; it has been noted by GNATS.

From: "Kamil Rytarowski" <kamil%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/51633 CVS commit: src/tests/lib/libpthread_dbg
Date: Sat, 19 Nov 2016 02:30:54 +0000

 Module Name:	src
 Committed By:	kamil
 Date:		Sat Nov 19 02:30:54 UTC 2016
 
 Modified Files:
 	src/tests/lib/libpthread_dbg: h_common.h
 
 Log Message:
 Fix basic_proc_read in pthread_dbg functions
 
 Source and destination were swapped. The source of this confusion was that
 running these tests under gdb(1) will generate false positives as it will
 initialize pthread__dbg to PID of the debugger. This means that it is
 currently not possible to debug pthread_dbg code under a full-stack
 debugger using NetBSD debugging library for threads.
 
 This should address:
 PR lib/51633 tests/lib/libpthread_dbg/t_dummy unreliable
 PR lib/51635: td_thr_iter in <pthread_dbg.h> seems broken
 
 After applying the fix I'm able to run all pthread_dbg tests without
 indeterminism. The indeterminism was caused by overwritting source of data
 with trash.
 
 Sponsored by <The NetBSD Foundation>
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.1 -r1.2 src/tests/lib/libpthread_dbg/h_common.h
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.