Re: PR/51437 CVS commit: src/usr.sbin/nfsd

[Hauke Fath <hf%spg.tu-darmstadt.de@localhost>]

The following reply was made to PR bin/51437; it has been noted by GNATS.

From: Hauke Fath <hf%spg.tu-darmstadt.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: gnats-admin%NetBSD.org@localhost, Christos Zoulas <christos%NetBSD.org@localhost>
Subject: Re: PR/51437 CVS commit: src/usr.sbin/nfsd
Date: Tue, 23 Aug 2016 12:18:26 +0200

 On 08/22/16 18:10, Christos Zoulas wrote:
 >  Modified Files:
 >  	src/usr.sbin/nfsd: nfsd.c
 
 Thanks, that was quick!
 
 I applied the following to netbsd-7:
 
 
 Index: nfsd.c
 ===================================================================
 RCS file: /cvsroot/src/usr.sbin/nfsd/nfsd.c,v
 retrieving revision 1.62.4.1
 diff -u -u -r1.62.4.1 nfsd.c
 --- nfsd.c      14 Apr 2015 05:14:17 -0000      1.62.4.1
 +++ nfsd.c      23 Aug 2016 10:13:26 -0000
 @@ -301,6 +301,7 @@
           case 0:
                   /* child */
                   (void)close(detach_msg_pipe[0]);
 +                (void)write(detach_msg_pipe[1], "", 1);
                   return detach_msg_pipe[1];
           default:
                   break;
 @@ -468,6 +469,8 @@
 
          if (debug == 0) {
                  parent_fd = daemon2_fork();
 +               if (parent_fd == -1)
 +                       syslog(LOG_ERR, "daemon2_fork failed");
          }
 
          openlog("nfsd", LOG_PID, LOG_DAEMON);
 
 
 Alternatively, we could just pull up the -current state to -7?
 
 Cheerio,
 Hauke