Re: port-amd64/50733: (Only) partial failure of laptop sleep (ACPI S3)

[coypu%SDF.ORG@localhost]

The following reply was made to PR port-amd64/50733; it has been noted by GNATS.

From: coypu%SDF.ORG@localhost
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: port-amd64/50733: (Only) partial failure of laptop sleep (ACPI
 S3)
Date: Sat, 6 Aug 2016 11:08:39 +0000

 --d6Gm4EdcadzBjdND
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 With this diff, disabling gpio_resume's functionality, I am able to
 resume successfully.
 
 gpio at ichlpcib is apparently wired to dangerous things on my machine,
 and merely restoring the old values after a resume causes it to crash.
 
 --d6Gm4EdcadzBjdND
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename="gpio.diff"
 
 Index: gpio/gpio.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/gpio/gpio.c,v
 retrieving revision 1.58
 diff -u -r1.58 gpio.c
 --- gpio/gpio.c	11 May 2016 18:33:40 -0000	1.58
 +++ gpio/gpio.c	5 Aug 2016 18:13:45 -0000
 @@ -136,13 +136,14 @@
  static bool
  gpio_resume(device_t self, const pmf_qual_t *qual)
  {
 +#if 0
  	struct gpio_softc *sc = device_private(self);
  	int pin;
 -
  	for (pin = 0; pin < sc->sc_npins; pin++) {
  		gpiobus_pin_ctl(sc->sc_gc, pin, sc->sc_pins[pin].pin_flags);
  		gpiobus_pin_write(sc->sc_gc, pin, sc->sc_pins[pin].pin_state);
  	}
 +#endif
  	return true;
  }
  
 
 --d6Gm4EdcadzBjdND--