Re: port-mips/51384: src/sys/arch/mips/rmi/rmixl_intr.c:981: 32/64 bit mixup ?

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR port-mips/51384; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: port-mips/51384: src/sys/arch/mips/rmi/rmixl_intr.c:981: 32/64
 bit mixup ?
Date: Mon, 1 Aug 2016 18:10:30 +0000

 On Mon, Aug 01, 2016 at 06:10:01PM +0000, David Holland wrote:
  >  On Mon, Aug 01, 2016 at 03:40:00PM +0000, dcb314%hotmail.com@localhost wrote:
  >   > Source code is
  >   > 
  >   >    const uint64_t ipi_mask = 1 << (uintptr_t)arg;
  >   > 
  >   > Maybe better code
  >   > 
  >   >    const uint64_t ipi_mask = 1ULL << (uintptr_t)arg;
  >  
  >  I suspect what they meant was (uintptr_t)1 << arg...
 
 hrm, guess not since arg is a void *. shrug... anyway, fixed
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost