Re: kern/49323

[Joerg Sonnenberger <joerg%bec.de@localhost>]

The following reply was made to PR kern/49323; it has been noted by GNATS.

From: Joerg Sonnenberger <joerg%bec.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
	netbsd-bugs%netbsd.org@localhost, ryoon%NetBSD.org@localhost
Subject: Re: kern/49323
Date: Wed, 29 Jun 2016 17:10:23 +0200

 On Wed, Jun 29, 2016 at 02:35:01PM +0000, Moroo Akira wrote:
 >  Index: x86/x86/ioapic.c
 >  ===================================================================
 >  RCS file: /cvsroot/src/sys/arch/x86/x86/ioapic.c,v
 >  retrieving revision 1.52
 >  diff -c -r1.52 ioapic.c
 >  *** x86/x86/ioapic.c	27 Jul 2015 15:45:20 -0000	1.52
 >  --- x86/x86/ioapic.c	29 Jun 2016 12:11:25 -0000
 >  ***************
 >  *** 549,554 ****
 >  --- 550,556 ----
 >    	flags = ioapic_lock(sc);
 >    	redlo = ioapic_read_ul(sc, IOAPIC_REDLO(pin));
 >    	redlo &= ~IOAPIC_REDLO_MASK;
 >  + 	redlo &= ~IOAPIC_REDLO_RIRR;
 >    	ioapic_write_ul(sc, IOAPIC_REDLO(pin), redlo);
 >    	ioapic_unlock(sc, flags);
 >    }
 
 Combine the masks?
 
 >  Index: amd64/include/i82093reg.h
 >  ===================================================================
 >  RCS file: /cvsroot/src/sys/arch/amd64/include/i82093reg.h,v
 >  retrieving revision 1.5
 >  diff -c -r1.5 i82093reg.h
 >  *** amd64/include/i82093reg.h	3 Jul 2008 14:02:25 -0000	1.5
 >  --- amd64/include/i82093reg.h	29 Jun 2016 12:13:55 -0000
 >  ***************
 >  *** 67,72 ****
 >  --- 68,74 ----
 >    	movl	%esi, (%r15)					;\
 >    	movl	(%r13),%r12d					;\
 >    	andl	$~IOAPIC_REDLO_MASK,%r12d			;\
 >  + 	andl	$~IOAPIC_REDLO_RIRR,%r12d			;\
 >    	movl	%esi,(%r15)					;\
 >    	movl	%r12d,(%r13)					;\
 >    	movq	IS_PIC(%r14),%rdi				;\
 
 Here too?
 
 Joerg