Re: PR/51230 CVS commit: src/sbin/gpt

[Robert Elz <kre%munnari.OZ.AU@localhost>]

The following reply was made to PR bin/51230; it has been noted by GNATS.

From: Robert Elz <kre%munnari.OZ.AU@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: christos%zoulas.com@localhost (Christos Zoulas), Hauke Fath <hf%spg.tu-darmstadt.de@localhost>
Subject: Re: PR/51230 CVS commit: src/sbin/gpt
Date: Fri, 10 Jun 2016 01:13:37 +0700

 christos%zoulas.com@localhost said:
 |  On Jun 9,  5:32pm, hf%spg.tu-darmstadt.de@localhost (Hauke Fath) wrote:
 |  -- Subject: Re: PR/51230 CVS commit: src/sbin/gpt
 |    | On Thu,  9 Jun 2016 15:15:01 +0000 (UTC), Christos Zoulas wrote:
 |  | > PR/51230: Add the ability to set the active flag in the PMBR.
 |  | 
 |  | Thanks! But...
 |  | 
 |  | # bin/gpt-current sd0 biosboot -a -i1
 |  | gpt-current: unknown option -- a
 |  | Usage: gpt-current <device> biosboot [-c bootcode] [-i index] [-L label]
 |  | #  
 | Hmm...
 
 Yes, it works for me too, just the same as it does for you (though I
 used /tmp/V instead of foo ...)   I suspect that Hauk somehow used a
 different version of gpt than the one he intended to use, as the only
 way to get getopt() to display the
 	gpt-current: unknown option -- a
 is if 'a' isn't in the getopt option string (for biosboot in this case)
 which it clearly was.
 
 Also, since the version he used appears to support "gpt device command"
 whereas as best I can tell, the standard version only supports
 "gpt command device", that also strongly hints that his test was using
 the wrong gpt binary.
 
 I would suggest changing the -a's that you added to -A though, the
 biosboot help message is currently...
 
 static const char *biosboothelp[] = {
         "[-a] [-c bootcode] [-i index] [-L label]",
 #if notyet
         "[-a alignment] [-b blocknr] [-i index] [-l label]",
         "[-s size] [-t type]",
 #endif
 };
 
 If that "notyet" #if goes away, and biosboot supports some of those
 options, there could be something of a mess (though why biosboot would
 ever want an alignment, or size or type, option, I cannot fathom.)
 
 But s/a/A/ is a cheap change to make now before the new -a usage becomes
 known.
 
 kre