NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

PR/50998 CVS commit: src/bin/pax



The following reply was made to PR bin/50998; it has been noted by GNATS.

From: "David A. Holland" <dholland%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/50998 CVS commit: src/bin/pax
Date: Tue, 31 May 2016 03:32:36 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Tue May 31 03:32:36 UTC 2016
 
 Modified Files:
 	src/bin/pax: ar_io.c
 
 Log Message:
 Don't use the length return from snprintf to write out the result
 buffer. If snprintf truncated the output, the length returned will be
 greater and we'll write trash. Just call strlen instead. (And since
 what we're doing is writing progress messages to the user, checking
 carefully for truncation isn't really worthwhile either.)
 
 Spotted when attending to PR 50998 from David Binderman; the issue
 there (computation of an unused value) popped up because one of the
 prints was already calling strlen.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.56 -r1.57 src/bin/pax/ar_io.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.
 


Home | Main Index | Thread Index | Old Index