PR/50759 CVS commit: src/sys/arch/x68k/dev

["David A. Holland" <dholland%netbsd.org@localhost>]

The following reply was made to PR port-x68k/50759; it has been noted by GNATS.

From: "David A. Holland" <dholland%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/50759 CVS commit: src/sys/arch/x68k/dev
Date: Tue, 31 May 2016 03:22:30 +0000

 Module Name:	src
 Committed By:	dholland
 Date:		Tue May 31 03:22:30 UTC 2016
 
 Modified Files:
 	src/sys/arch/x68k/dev: zs.c
 
 Log Message:
 PR 50759 David Binderman: fix out of bounds array access.
 
 If we don't find one of the expected device addresses, reject the
 match, but do it by checking whether the loop matched something rather
 than by testing an array entry that might be one past the end.
 
 Note: I have also moved the test to be with the loop; since the call
 to intio_map_allocate_region had gotten placed in between them, I've
 moved it to go before rather than after them as (a) it doesn't
 interact with the loop itself and (b) this seems like the best choice
 given the history as it was deliberately added before the original
 test.
 
 I have not tried running this, not having an x68k, but as best I can
 tell by reading the intio code it seems like it should be harmless
 even if it's not really correct.
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.42 -r1.43 src/sys/arch/x68k/dev/zs.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.