port-zaurus/51195: src/sys/arch/zaurus/stand/zboot/boot.c:448]: (style) Redundant condition

[dcb314%hotmail.com@localhost]

>Number:         51195
>Category:       port-zaurus
>Synopsis:       src/sys/arch/zaurus/stand/zboot/boot.c:448]: (style) Redundant condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-zaurus-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 30 13:25:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160529
>Organization:
>Environment:
>Description:

src/sys/arch/zaurus/stand/zboot/boot.c:448]: (style) Redundant condition: If 'EXPR == ' '', the comparison 'EXPR' is always true.

Source code is

   while (*options && *options == ' ')

Suggest new code

    while (*options == ' ')

Also in the same file

[src/sys/arch/zaurus/stand/zboot/boot.c:419]: (warning) Obsolete function 'gets' called. It is recommended to use 'fgets' or 'gets_s' instead.

>How-To-Repeat:

>Fix: