NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

bin/51192: src/usr.bin/tip/aculib/v831.c:252]: (style) Redundant condition



>Number:         51192
>Category:       bin
>Synopsis:       src/usr.bin/tip/aculib/v831.c:252]: (style) Redundant condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 30 13:15:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160529
>Organization:
>Environment:
>Description:
src/usr.bin/tip/aculib/v831.c:252]: (style) Redundant condition: If 'EXPR == '<'', the comparison 'EXPR != '_'' is always true.

Source code is

    if (!isdigit((unsigned char)*s) && *s == '<' && *s != '_')

Suggest new code

    if (!isdigit((unsigned char)*s) && *s == '<')

>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index