port-sparc/51188: src/sys/arch/sparc/stand/ofwboot/boot.c: 2 * Redundant condition

[dcb314%hotmail.com@localhost]

>Number:         51188
>Category:       port-sparc
>Synopsis:       src/sys/arch/sparc/stand/ofwboot/boot.c: 2 * Redundant condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-sparc-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon May 30 06:25:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160529
>Organization:
>Environment:
>Description:
src/sys/arch/sparc/stand/ofwboot/boot.c:144]: (style) Redundant condition: If 'EXPR == ' '', the comparison 'EXPR != 0' is always true.

Source code is

     while (*ap != '\0' && *ap == ' ') {

Suggest new code

    while (*ap == ' ') {

[src/sys/arch/sparc/stand/ofwboot/boot.c:154]: (style) Redundant condition: If 'EXPR == ' '', the comparison 'EXPR != 0' is always true.

Source code is

           while (*ap != '\0' && *ap == ' ') {

Also in the same file

[src/sys/arch/sparc/stand/ofwboot/boot.c:466]: (warning) Obsolete function 'gets' called. It is recommended to use 'fgets' or 'gets_s' instead.

>How-To-Repeat:

>Fix: