NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/51184: src/sys/dev/firmload.c:146]: (style) Redundant condition



>Number:         51184
>Category:       kern
>Synopsis:       src/sys/dev/firmload.c:146]: (style) Redundant condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun May 29 17:25:01 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160529
>Organization:
>Environment:
>Description:
src/sys/dev/firmload.c:146]: (style) Redundant condition: If 'EXPR == 0', the comparison 'EXPR != '/'' is always true.


Source code is

    if (prefix == NULL      /* terminated early */
        || *prefix == '\0'      /* no more left */
        || *prefix != '/') {    /* not absolute */


Suggest code rework.
>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index