Re: kern/51167: alc(4) promiscuous mode is broken

[coypu%SDF.ORG@localhost]

The following reply was made to PR kern/51167; it has been noted by GNATS.

From: coypu%SDF.ORG@localhost
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/51167: alc(4) promiscuous mode is broken
Date: Thu, 26 May 2016 02:27:41 +0000

 Alternative that also worked (clearer):
 
 --- a/sys/dev/pci/if_alc.c
 +++ b/sys/dev/pci/if_alc.c
 @@ -3413,7 +3413,6 @@ alc_iff(struct alc_softc *sc)
  	rxcfg |= MAC_CFG_BCAST;
  
  	if (ifp->if_flags & IFF_PROMISC || ec->ec_multicnt > 0) {
 -		ifp->if_flags |= IFF_ALLMULTI;
  		if (ifp->if_flags & IFF_PROMISC)
  			rxcfg |= MAC_CFG_PROMISC;
  		else