install/51084: 'build.sh release' fails with MAKEVERBOSE >= 3

[paul%whooppee.com@localhost]

>Number:         51084
>Category:       install
>Synopsis:       'build.sh release' fails with MAKEVERBOSE >= 3
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Apr 21 22:45:00 +0000 2016
>Originator:     Paul Goyette
>Release:        NetBSD 7.99.26
>Organization:
+------------------+--------------------------+------------------------+
| Paul Goyette     | PGP Key fingerprint:     | E-mail addresses:      |
| (Retired)        | FA29 0E3B 35AF E8AE 6651 | paul at whooppee.com   |
| Kernel Developer | 0786 F758 55DE 53BA 7731 | pgoyette at netbsd.org |
+------------------+--------------------------+------------------------+
>Environment:
	
	
System: NetBSD pokey.whooppee.com 7.99.26 NetBSD 7.99.26 (POKEY 2016-02-16 03:01:55) #0: Tue Feb 16 12:33:45 PHT 2016 paul%pokey.whooppee.com@localhost:/build/netbsd-local/obj/amd64/sys/arch/amd64/compile/POKEY amd64
Architecture: x86_64
Machine: amd64
>Description:
	(This PR relates to the NetBSD build environment.  If "install"
	is an incorrect category, please feel free to update!)

	If you invoke 'build.sh release' with MAKEVERBOSE set to a value
	of 3 or more, the build system sets MAKEFLAGS to "-dl" or "-dx"
	to force make(1) to display the shell commands in each target's
	build script.

	This causes the output of the arch_to_cpu() function in file
	src/distrib/sets/sets.subr to include the 'echo' command, as
	well as its output, and the echo command is then included in
	the value of ${MACHINE_CPU}.  This, in turn, causes the awk
	script in function list_set_files() to fail.

	/build/netbsd-local/tools/x86_64/amd64/bin/nbawk: non-terminated string echo x86_6... at source line 70
	 context is
	                                        wanted["machine_cpu=" "echo x86_64

	
>How-To-Repeat:
	Just invoke 

		# cd $srcdir
		# ./build.sh -V MAKEVERBOSE=3 release
	
>Fix:
	While almost certainly not a correct fix, the following patch to
	sets.subr demonstrates the source/cause of the problem:

Index: sets.subr
===================================================================
RCS file: /cvsroot/src/distrib/sets/sets.subr,v
retrieving revision 1.174
diff -u -p -r1.174 sets.subr
--- sets.subr   21 Feb 2016 04:16:36 -0000      1.174
+++ sets.subr   21 Apr 2016 08:21:30 -0000
@@ -648,6 +648,11 @@ print_set_lists()
 #
 arch_to_cpu()
 {
+       # set +x        # unfortunately, if this is needed, it won't help!
+       unset MAKEVERBOSE
+       unset MAKEFLAGS
+       exec 2> /dev/null       # just in case
+
 	MACHINE_ARCH=${1} ${MAKE} -B -f- all <<EOMAKE
 .include <bsd.own.mk>
 all:

	

>Unformatted: