PR/50993 CVS commit: src/bin/sh

["Christos Zoulas" <christos%netbsd.org@localhost>]

The following reply was made to PR bin/50993; it has been noted by GNATS.

From: "Christos Zoulas" <christos%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/50993 CVS commit: src/bin/sh
Date: Thu, 31 Mar 2016 09:27:44 -0400

 Module Name:	src
 Committed By:	christos
 Date:		Thu Mar 31 13:27:44 UTC 2016
 
 Modified Files:
 	src/bin/sh: expand.c
 
 Log Message:
 After discussions with Jilles Tjoelker (FreeBSD shell) and following
 a suggestion from him, the way the fix to PR bin/50993 was implemented
 has changed a little.   There are three steps involved in processing
 a here document, reading it, parsing it, and then evaluating it
 before applying it to the correct file descriptor for the command
 to use.  The third of those is not related to this problem, and
 has not changed.  The bug was caused by combining the first two
 steps into one (and not doing it correctly - which would be hard
 that way.)  The fix is to split the first two stages into separate
 events.   The original fix moved the 2nd stage (parsing) to just
 immediately before the 3rd stage (evaluation.)  Jilles pointed out
 some unwanted side effects from doing it that way, and suggested
 moving the 2nd stage to immediately after the first.  This commit
 makes that change.  The effect is to revert the changes to expand.c
 and parser.h (which are no longer needed) and simplify slightly
 the change to parser.c. (from kre@)
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.99 -r1.100 src/bin/sh/expand.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.