Re: PR/50951 CVS commit: src/sys/fs/cd9660

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/50951; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: PR/50951 CVS commit: src/sys/fs/cd9660
Date: Sat, 12 Mar 2016 01:48:36 +0000

 On Fri, Mar 11, 2016 at 06:40:00PM +0000, Christos Zoulas wrote:
  >  Modified Files:
  >  	src/sys/fs/cd9660: cd9660_vnops.c
  >  
  >  Log Message:
  >  PR/50951: David Binderman: Fix misplaced parens
  > 
  > -       if ((assoc = cl > 1 && *cname == ASSOCCHAR)) {
  > +       if ((assoc = cl) > 1 && *cname == ASSOCCHAR) {
 
 
 ...speaking of potentially messing up, I think this one ought to be
 
         if ((assoc = (cl > 1)) && *cname == ASSOCCHAR) {
 
 based on the use of "assoc" further down in the function.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost