kern/50951: src/sys/fs/cd9660/cd9660_vnops.c:322]: style) Suspicious condition

[dcb314%hotmail.com@localhost]

>Number:         50951
>Category:       kern
>Synopsis:       src/sys/fs/cd9660/cd9660_vnops.c:322]: style) Suspicious condition
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Mar 11 17:25:01 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160311
>Organization:
>Environment:
>Description:

src/sys/fs/cd9660/cd9660_vnops.c:322]: (style) Suspicious condition (assignment + comparison); Clarify expression with parentheses.


Source code is

    if ((assoc = cl > 1 && *cname == ASSOCCHAR)) {


Maybe better code

     if (((assoc = (cl > 1)) != 0 && *cname == ASSOCCHAR)) {




 


   

  



>How-To-Repeat:

>Fix: