RE: bin/50909: src/sbin/ifconfig/env.c: 2 * clumsy call to memset ?

[David Binderman <dcb314%hotmail.com@localhost>]

The following reply was made to PR bin/50909; it has been noted by GNATS.

From: David Binderman <dcb314%hotmail.com@localhost>
To: "gnats-bugs%NetBSD.org@localhost" <gnats-bugs%netbsd.org@localhost>
Cc: 
Subject: RE: bin/50909: src/sbin/ifconfig/env.c: 2 * clumsy call to memset ?
Date: Mon, 7 Mar 2016 12:26:06 +0000

 Hello there=2C=0A=
 =0A=
 ----------------------------------------=0A=
 > From: gnats-admin%netbsd.org@localhost=0A=
 > To: dcb314%hotmail.com@localhost=0A=
 > Subject: Re: bin/50909: src/sbin/ifconfig/env.c: 2 * clumsy call to memse=
 t ?=0A=
 > Date: Mon=2C 7 Mar 2016 12:20:00 +0000=0A=
 >=0A=
 > Thank you very much for your problem report.=0A=
 > It has the internal identification `bin/50909'.=0A=
 > The individual assigned to look at your=0A=
 > report is: bin-bug-people.=0A=
 >=0A=
 >>Category: bin=0A=
 >>Responsible: bin-bug-people=0A=
 >>Synopsis: src/sbin/ifconfig/env.c: 2 * clumsy call to memset ?=0A=
 >>Arrival-Date: Mon Mar 07 12:20:00 +0000 2016=0A=
 >=0A=
 =0A=
 I should have mentioned the second clumsy call:=0A=
 =0A=
 [src/sbin/ifconfig/env.c:166]: (performance) Buffer 'buf' is being written =
 before its old content has been used.=0A=
 =0A=
 Source code is=0A=
 =0A=
 =A0=A0=A0 memset(buf=2C 0=2C buflen)=3B=0A=
 =A0=A0=A0 memcpy(buf=2C prop_data_data_nocopy(data)=2C datalen)=3B=0A=
 =0A=
 This looks like a duplicate of the earlier code.=0A=
 =0A=
 =0A=
 Regards=0A=
 =0A=
 David Binderman=0A=
  		 	   		  =