NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/50898: src/sys/dev/pci/n8/common/api/n8_rsa.c: pointless call to memset ?



>Number:         50898
>Category:       kern
>Synopsis:       src/sys/dev/pci/n8/common/api/n8_rsa.c: pointless call to memset ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Mar 06 17:20:01 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160305
>Organization:
>Environment:
>Description:
[src/sys/dev/pci/n8/common/api/n8_rsa.c:1075] -> [src/sys/dev/pci/n8/common/api/n8_rsa.c:1090]: (performance) Buffer 'vAddr' is being written before its old content has been used.

     memset(vAddr, 0, nBytes);

      memset(vAddr, 0x0, padding);

The second one looks redundant to me.

>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index