Re: misc/50893: dhcpd fails on carp(4) interfaces

[Bruce Lilly <bruce.lilly%gmail.com@localhost>]

The following reply was made to PR misc/50893; it has been noted by GNATS.

From: Bruce Lilly <bruce.lilly%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: misc-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: misc/50893: dhcpd fails on carp(4) interfaces
Date: Fri, 4 Mar 2016 14:45:37 -0500

 Modified dhcpd:
 
 # ls -l $(whence dhcpd)
 -r-xr-xr-x   1 root     wheel     724463 Mar  4 14:05 /usr/sbin/dhcpd
 
 Restart with carp interfaces active, patched /etc/rc.d/dhcpd:
 
 2016-03-04T14:33:52.084407-05:00 z400a.blilly.net dhcpd - - - Received
 signal 15, initiating shutdown.
 2016-03-04T14:33:54.138046-05:00 z400a.blilly.net dhcpd - - - Internet
 Systems Consortium DHCP Server 4.3.0
 2016-03-04T14:33:54.138386-05:00 z400a.blilly.net dhcpd - - -
 Copyright 2004-2014 Internet Systems Consortium.
 2016-03-04T14:33:54.138414-05:00 z400a.blilly.net dhcpd - - - All
 rights reserved.
 2016-03-04T14:33:54.138439-05:00 z400a.blilly.net dhcpd - - - For
 info, please visit https://www.isc.org/software/dhcp/
 2016-03-04T14:33:54.139769-05:00 z400a.blilly.net dhcpd - - - Wrote 0
 deleted host decls to leases file.
 2016-03-04T14:33:54.139839-05:00 z400a.blilly.net dhcpd - - - Wrote 0
 new dynamic host decls to leases file.
 2016-03-04T14:33:54.140029-05:00 z400a.blilly.net dhcpd - - - Wrote 8
 leases to leases file.
 2016-03-04T14:33:54.140530-05:00 z400a.blilly.net dhcpd - - - Multiple
 interfaces match the same subnet: bge0 carp0
 2016-03-04T14:33:54.140564-05:00 z400a.blilly.net dhcpd - - - Multiple
 interfaces match the same shared network: bge0 carp0
 2016-03-04T14:33:54.141023-05:00 z400a.blilly.net dhcpd - - - Server
 starting service.
 
 As before.
 
 Restart with original /etc/rc.d/dhcpd:
 
 2016-03-04T14:37:58.953806-05:00 z400a.blilly.net dhcpd - - - Received
 signal 15, initiating shutdown.
 2016-03-04T14:38:00.995491-05:00 z400a.blilly.net dhcpd - - - Internet
 Systems Consortium DHCP Server 4.3.0
 2016-03-04T14:38:00.995838-05:00 z400a.blilly.net dhcpd - - -
 Copyright 2004-2014 Internet Systems Consortium.
 2016-03-04T14:38:00.995872-05:00 z400a.blilly.net dhcpd - - - All
 rights reserved.
 2016-03-04T14:38:00.995905-05:00 z400a.blilly.net dhcpd - - - For
 info, please visit https://www.isc.org/software/dhcp/
 2016-03-04T14:38:00.996545-05:00 z400a.blilly.net dhcpd - - - Wrote 0
 deleted host decls to leases file.
 2016-03-04T14:38:00.996616-05:00 z400a.blilly.net dhcpd - - - Wrote 0
 new dynamic host decls to leases file.
 2016-03-04T14:38:00.996785-05:00 z400a.blilly.net dhcpd - - - Wrote 8
 leases to leases file.
 2016-03-04T14:38:00.997040-05:00 z400a.blilly.net dhcpd - - - Multiple
 interfaces match the same subnet: bge0 carp0
 2016-03-04T14:38:00.997072-05:00 z400a.blilly.net dhcpd - - - Multiple
 interfaces match the same shared network: bge0 carp0
 2016-03-04T14:38:00.997395-05:00 z400a.blilly.net dhcpd - - - Server
 starting service.
 
 That appears to have corrected the 'Unsupported device type 248 for
 "carp0"' and resulting bail-out of dhcpd; thanks.
 
 On Fri, Mar 4, 2016 at 10:30 AM, Christos Zoulas <christos%zoulas.com@localhost> wrote:
 > The following reply was made to PR misc/50893; it has been noted by GNATS.
 >
 > From: christos%zoulas.com@localhost (Christos Zoulas)
 > To: gnats-bugs%NetBSD.org@localhost, misc-bug-people%netbsd.org@localhost,
 >         gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
 > Cc:
 > Subject: Re: misc/50893: dhcpd fails on carp(4) interfaces
 > Date: Fri, 4 Mar 2016 10:27:05 -0500
 >
 >  On Mar 4,  3:15pm, bruce.lilly%gmail.com@localhost (bruce.lilly%gmail.com@localhost) wrote:
 >  -- Subject: misc/50893: dhcpd fails on carp(4) interfaces
 >
 >  | >Number:         50893
 >  | >Category:       misc
 >  | >Synopsis:       dhcpd fails on carp(4) interfaces
 >  | >Confidential:   no
 >  | >Severity:       serious
 >  | >Priority:       medium
 >  | >Responsible:    misc-bug-people
 >  | >State:          open
 >  | >Class:          sw-bug
 >  | >Submitter-Id:   net
 >  | >Arrival-Date:   Fri Mar 04 15:15:00 +0000 2016
 >  | >Originator:     Bruce Lilly
 >  | >Release:        NetBSD 7.0
 >  | >Organization:
 >  | >Environment:
 >  | (you don't need the node name; here's ouput of uname -srmpio:)
 >  |
 >
 >  Can you please try this?
 >
 >  christos
 >
 >  Index: bpf.c
 >  ===================================================================
 >  RCS file: /cvsroot/src/external/bsd/dhcp/dist/common/bpf.c,v
 >  retrieving revision 1.3
 >  diff -u -u -r1.3 bpf.c
 >  --- bpf.c      12 Jul 2014 12:09:37 -0000      1.3
 >  +++ bpf.c      4 Mar 2016 15:26:53 -0000
 >  @@ -623,6 +623,7 @@
 >          */
 >           switch (sa->sdl_type) {
 >                   case IFT_ETHER:
 >  +              case IFT_CARP:
 >                           hw->hlen = sa->sdl_alen + 1;
 >                           hw->hbuf[0] = HTYPE_ETHER;
 >                           memcpy(&hw->hbuf[1], LLADDR(sa), sa->sdl_alen);
 >