kern/50874: src/sys/dev/pci/n8/common/n8_SKSManager.c:139: pointless test ?

[dcb314%hotmail.com@localhost]

>Number:         50874
>Category:       kern
>Synopsis:       src/sys/dev/pci/n8/common/n8_SKSManager.c:139: pointless test ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 29 17:50:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160229
>Organization:
>Environment:
>Description:

src/sys/dev/pci/n8/common/n8_SKSManager.c:139]: (style) Checking if unsigned variable 'targetSKS' is less than zero.

Source code is

   if ((targetSKS < 0) || (targetSKS >= NSPcount_g))

but

N8_Status_t n8_SKSWrite(const unsigned int targetSKS,

>How-To-Repeat:

>Fix: