NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

port-hppa/50871: src/sys/arch/hppa/spmath/sfsqrt.c:153: weird coding ?



>Number:         50871
>Category:       port-hppa
>Synopsis:       src/sys/arch/hppa/spmath/sfsqrt.c:153: weird coding ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-hppa-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Feb 29 17:45:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160229
>Organization:
>Environment:
>Description:

src/sys/arch/hppa/spmath/sfsqrt.c:153]: (style) Boolean result is used in bitwise operation. Clarify expression with parentheses.


Source code is

         if (!even_exponent & Sgl_islessthan(result,src))
            Sgl_increment(result);


Looks weird. Did someone muxup & and && ?

>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index