PR/40764 CVS commit: src/sys/kern

["Paul Goyette" <pgoyette%netbsd.org@localhost>]

The following reply was made to PR kern/40764; it has been noted by GNATS.

From: "Paul Goyette" <pgoyette%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc: 
Subject: PR/40764 CVS commit: src/sys/kern
Date: Sat, 6 Feb 2016 22:48:07 +0000

 Module Name:	src
 Committed By:	pgoyette
 Date:		Sat Feb  6 22:48:07 UTC 2016
 
 Modified Files:
 	src/sys/kern: kern_module.c
 
 Log Message:
 In module_do_load(), consolidate checking for a pre-existing module,
 and return a single error value EEXIST.  When making a recursive
 call (to load required modules), treat a pre-existing module as
 success.
 
 Without this change, when a module was loaded by specific request
 (as opposed to being loaded as a requirement of some other module),
 we would always load the module from the file-system, and then
 after making various sanity/compatability checks we would destroy
 the new copy if there was a pre-existing copy.
 
 Fixes PR kern/40764
 
 XXX Note that if the module exists, we bypass all of the various
 XXX "compatability" checks, including whether or not the existing
 XXX module is of any particular class!  (In the previous code, we
 XXX checked to see if the newly-loaded copy had the correct class,
 XXX but not the pre-existing copy, which could have been loaded
 XXX from a different path/filename.)
 
 
 To generate a diff of this commit:
 cvs rdiff -u -r1.109 -r1.110 src/sys/kern/kern_module.c
 
 Please note that diffs are not public domain; they are subject to the
 copyright notices on the relevant files.