NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: PR/50768 CVS commit: src/usr.bin/units

The following reply was made to PR bin/50768; it has been noted by GNATS.

From: David Holland <>
Subject: Re: PR/50768 CVS commit: src/usr.bin/units
Date: Fri, 5 Feb 2016 03:52:05 +0000

 On Fri, Feb 05, 2016 at 03:35:01AM +0000, David A. Holland wrote:
  >  Log Message:
  >  Improve the parser. Now we understand negative exponents; fixes PR 50768.
  >  Also handle negative numbers better in general (don't randomly drop
  >  the sign in a number of cases) and don't choke on exponents > 9.
  >  This commit alters the meaning of a few previously valid but marginal
  >  inputs (e.g. "3 foot-5 pound" is now treated as "3*-5 foot-pound"
  >  rather than "3*5 foot-pound"; if you want the latter insert another
  >  space) but corrects obviously wrong handling of many more.
  >  To generate a diff of this commit:
  >  cvs rdiff -u -r1.25 -r1.26 src/usr.bin/units/units.c
 This is now fixed, but should be pulled up to -7 and probably -6, but
 I want to wait a bit first.
 Anyone who wants to swipe the patch note that you also almost
 certainly want -r1.27 of units.c.
 (the issue seems to date back and it affects other variants of units,
 including e.g. Apple's.)
 David A. Holland

Home | Main Index | Thread Index | Old Index