NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: toolchain/50731: config(8) adds bogus directories to include path

The following reply was made to PR toolchain/50731; it has been noted by GNATS.

From: Masao Uebayashi <>
Subject: Re: toolchain/50731: config(8) adds bogus directories to include path
Date: Thu, 4 Feb 2016 11:13:44 +0900

 On Tue, Feb 2, 2016 at 9:45 PM, Rin Okuyama
 <> wrote:
 >  >   >   % cat sys/external/bsd/acpica/conf/files.acpica
 >  >   >   ...
 >  >   >   makeoptions     acpi    CPPFLAGS+="-I$S/external/bsd/acpica/dist/include"
 >  >   >   ...
 >  >   >   %
 >  Thank you for your comment. I agree with you about "makeoptions". I don't
 >  intend to encourage abuse of "makeoptions".
 >  I just mean that we should register a directory into include path, only
 >  if it is actually required. The "prefix" statement unconditionally adds
 >  its argument to EXTRA_INCLUDES. As a result, for example, the directory
 >  of libx86emu is registered into include path even for vax!
 >  The simplest solution would be (1) stop "prefix" emitting include path,
 >  and (2) add a sentence like this:
 >    emitinclude acpi external/bsd/acpica/dist/include
 >  However, you prefer to more sophisticated framework or notation for
 >  external kernel modules, don't you?
 I was only talking about the long term direction.  I come to think
 that the conditional "makeoptions" is one step foward, and I'm OK with

Home | Main Index | Thread Index | Old Index