Re: toolchain/50731: config(8) adds bogus directories to include path

[Rin Okuyama <okuyama%flex.phys.tohoku.ac.jp@localhost>]

The following reply was made to PR toolchain/50731; it has been noted by GNATS.

From: Rin Okuyama <okuyama%flex.phys.tohoku.ac.jp@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: toolchain/50731: config(8) adds bogus directories to include path
Date: Mon, 1 Feb 2016 21:00:12 +0900

 On 2016/02/01 2:45, David Holland wrote:
 >   I agree with all your reasoning, but I have an objection to the patch:
 >   I don't think it's a good idea to remove the %INCLUDES logic. We'll
 >   inevitably want it back sometime.
 
 Thank you for your comment. Then, we will have two options:
 
 (1) Leave the current implementation almost untouched; keep the variable
 "allprefixes" and logic related to it. In the final step, do not emit
 include path, like this:
 
                 if (strcmp(line, "%OBJS\n") == 0)
                         fn = Mflag ? emitkobjs : emitofiles;
                 else if ....
                 ....
                 else if (strcmp(line, "%INCLUDES\n") == 0)
 -                       fn = emitincludes;
 +                       fn = NULL;      /* reserved */
                 else if ....
                 ....
 -               (*fn)(ofp);
 +               if (fn != NULL)
 +                       (*fn)(ofp);
 
 (2) Leave the previous patch almost untouched; remove "allprefixes" and
 related logic. Only keep "%INCLUDES" as a reserved word.
 
 Which one sounds better to you? Or, any other idea?