port-arm/50687: src/sys/arch/arm/at91/at91emac.c:792: possible bad bitmask ?

[dcb314%hotmail.com@localhost]

>Number:         50687
>Category:       port-arm
>Synopsis:       src/sys/arch/arm/at91/at91emac.c:792: possible bad bitmask ?
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    port-arm-maintainer
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Jan 21 17:45:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160121
>Organization:
>Environment:
>Description:
[src/sys/arch/arm/at91/at91emac.c:792] -> [src/sys/arch/arm/at91/at91emac.c:792]: (style) Same expression on both sides of '|'.

source code is

    cfg &= ~(ETH_CFG_MTI | ETH_CFG_UNI | ETH_CFG_CAF | ETH_CFG_UNI);

At a simple level, it might be suitable to remove the duplicate.

However, there are a bunch of other bitmask values that might be appropriate.

Bitmask values listed in file src/sys/arch/arm/at91/at91emacreg.h
>How-To-Repeat:

>Fix: