NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

kern/50670: src/sys/netinet/ip_mroute.c:2415: misleading formatting ?



>Number:         50670
>Category:       kern
>Synopsis:       src/sys/netinet/ip_mroute.c:2415: misleading formatting ?
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Jan 17 09:50:00 +0000 2016
>Originator:     David Binderman
>Release:        cvs dated 20160116
>Organization:
>Environment:
>Description:
[src/sys/netinet/ip_mroute.c:2415]: (style) Expression is always false because 'else if' condition matches previous condition at line 2412.

    if (socket_send(viftable[vifi].v_rsvpd, m, &rsvp_src) < 0)
        if (rsvpdebug)
            printf("rsvp_input: Failed to append to socket\n");
    else
        if (rsvpdebug)
            printf("rsvp_input: send packet up\n");


Some { and } or some better formatting might help here.
>How-To-Repeat:

>Fix:



Home | Main Index | Thread Index | Old Index