NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/50483: assym.h is not rebuilt
The following reply was made to PR kern/50483; it has been noted by GNATS.
From: Masao Uebayashi <uebayasi%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc:
Subject: Re: kern/50483: assym.h is not rebuilt
Date: Sat, 28 Nov 2015 11:23:49 +0900
My regression, my bad.
I wanted to make DEPS symmetric with SRCS. I seem to have made a
mistake because of that.
I would fix this by making 'assym.d' be always built
(s/^assym.d:/assym.d!/ in sys/conf/assym.mk).
*
I can also point out that touching a *.h doesn't cause all other
indirect *.d to be regenerated, even on source before my rototill:
echo '#include <sys/foo.h>' >>sys/conf/param.c
echo '#include <sys/bar.h>' >sys/sys/foo.h
touch sys/sys/bar.h
(build kernel)
touch sys/sys/bar.h
(build kernel)
=> is param.d rebuilt?
=> is kernel rebuilt?
The easiest fix would be to make all *.d generation rule be always
built (s/xxx.d:/xxx.d!/) too.
On Sat, Nov 28, 2015 at 4:40 AM, <dholland%netbsd.org@localhost> wrote:
>>Number: 50483
>>Category: kern
>>Synopsis: assym.h is not rebuilt
>>Confidential: no
>>Severity: critical
>>Priority: high
>>Responsible: kern-bug-people
>>State: open
>>Class: sw-bug
>>Submitter-Id: net
>>Arrival-Date: Fri Nov 27 19:40:00 +0000 2015
>>Originator: David A. Holland
>>Release: NetBSD 7.99.21 (20151118)
>>Organization:
>>Environment:
> System: NetBSD valkyrie 7.99.1 NetBSD 7.99.1 (VALKYRIE) #17: Wed Oct 14 03:21:03 EDT 2015 dholland@valkyrie:/usr/src/sys/arch/amd64/compile/VALKYRIE amd64
> Architecture: x86_64
> Machine: amd64
>>Description:
>
> assym.h doesn't depend on the header files it's derived from. This
> results in out of date info and crashes in locore if core data
> structures are changed.
>
> Might be specific to amd64 but I assume most of the logic involved is
> MI.
>
> I doubt this has been true forever so it was probably caused by some
> of the recent config and kernel build rototilling.
>
>>How-To-Repeat:
>
> valkyrie% touch ../../../../sys/proc.h
> valkyrie% make assym.h
> `assym.h' is up to date.
> valkyrie%
>
>>Fix:
>
Home |
Main Index |
Thread Index |
Old Index