bin/50301: Build release broken on platforms without spawn.h

[joachim.kuebart%gmail.com@localhost]

>Number:         50301
>Category:       bin
>Synopsis:       Build release broken on platforms without spawn.h
>Confidential:   no
>Severity:       serious
>Priority:       low
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Mon Oct 05 06:40:00 +0000 2015
>Originator:     Joachim Kuebart
>Release:        NetBSD-7
>Organization:
>Environment:
NetBSD yacht 5.99.23 NetBSD 5.99.23 (YACHT) #0: Mon Jan 18 19:22:39 CEST 2010  joki@yacht:/usr/obj/amd64/usr/src/sys/arch/amd64/compile/YACHT amd64

>Description:
Building release (specifically, building tools for usr.bin/xinstall) is currently broken on platforms without spawn.h, such as previous versions of NetBSD like the one listed.

>How-To-Repeat:
cd /usr/src && build.sh tools

>Fix:
Apply the following to usr.bin/xinstall/Makefile to assume avoid relying on spawn.h while building tools:

Index: Makefile
===================================================================
RCS file: /pub/NetBSD-CVS/src/usr.bin/xinstall/Makefile,v
retrieving revision 1.25
diff -p -U8 -r1.25 Makefile
--- Makefile	17 Jun 2015 15:34:08 -0000	1.25
+++ Makefile	5 Oct 2015 06:31:58 -0000
@@ -7,19 +7,19 @@ PROG=	xinstall
 SRCS=	xinstall.c getid.c metachar.c
 MAN=	install.1
 
 .PATH:		${NETBSDSRCDIR}/usr.bin/make
 CPPFLAGS+=	-I${NETBSDSRCDIR}/usr.bin/make
 
 .PATH:		${NETBSDSRCDIR}/usr.sbin/mtree
 CPPFLAGS+=	-I${NETBSDSRCDIR}/usr.sbin/mtree
-CPPFLAGS+=	-DHAVE_POSIX_SPAWN
 
 .if (${HOSTPROG:U} == "")
+CPPFLAGS+=	-DHAVE_POSIX_SPAWN
 DPADD+= ${LIBUTIL}
 LDADD+= -lutil
 .endif
 
 COPTS.xinstall.c += -Wno-format-nonliteral
 
 
 PROGNAME=install